Merge pull request #208 from waterkip/GH-crappy-idps

Fix boolean values for integrations with crappy IdP's
perl-net-saml2 · Apr 17, 2024 · 0f0f8f9 · 0f0f8f9
2 parents 239d1b4 + bcfc4d2
commit 0f0f8f9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/Net/SAML2/SP.pm b/lib/Net/SAML2/SP.pm
@@ -609,8 +609,8 @@ sub generate_metadata {
         $x->SPSSODescriptor(
             $md,
             {
-                AuthnRequestsSigned        => $self->authnreq_signed,
-                WantAssertionsSigned       => $self->want_assertions_signed,
+                AuthnRequestsSigned        => $self->authnreq_signed ? 'true' : 'false',
+                WantAssertionsSigned       => $self->want_assertions_signed ? 'true' : 'false',
                 errorURL                   => $error_uri,
                 protocolSupportEnumeration => URN_PROTOCOL,
             },

diff --git a/t/02-create-sp.t b/t/02-create-sp.t
@@ -24,10 +24,10 @@ use URN::OASIS::SAML2 qw(:bindings :urn);
     my $node
         = get_single_node_ok($xpath,
         '//md:EntityDescriptor/md:SPSSODescriptor');
-    ok(!$node->getAttribute('WantAssertionsSigned'),
+    is($node->getAttribute('WantAssertionsSigned'), 'false',
         'Wants assertions to be signed');
-    ok(
-        !$node->getAttribute('AuthnRequestsSigned'),
+    is(
+        $node->getAttribute('AuthnRequestsSigned'), 'false',
         '.. and also authn requests to be signed'
     );
 
@@ -165,9 +165,9 @@ use URN::OASIS::SAML2 qw(:bindings :urn);
         # Test SPSSODescriptor
         my $node = get_single_node_ok($xpath, '/node()/md:SPSSODescriptor');
         is($node->getAttribute('AuthnRequestsSigned'),
-            '1', '.. and authn request needs signing');
+            'true', '.. and authn request needs signing');
         is($node->getAttribute('WantAssertionsSigned'),
-            '1', '.. as does assertions');
+            'true', '.. as does assertions');
         is($node->getAttribute('errorURL'),
             'http://localhost:3000/error', 'Got the correct error URI');
         is(