Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Provider Org URL is set incorrectly #18

Closed
timlegge opened this issue Feb 9, 2021 · 0 comments
Closed

Service Provider Org URL is set incorrectly #18

timlegge opened this issue Feb 9, 2021 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@timlegge
Copy link
Contributor

timlegge commented Feb 9, 2021

$x->OrganizationURL(

As reported by @wora55 there is a (minor) bug in metadata, where the Organization url is incorrectly defined, because it used $self->url.

It should likely be

$x->OrganizationURL(
$md,
{
'xml:lang' => 'en' },
$self->org_url || $self->url

and add another (optional) line for the object so existing modules would not have to be changed

https://github.com/perl-net-saml2/perl-Net-SAML2/blob/master/lib/Net/SAML2/SP.pm#L83

has 'org_contact' => (isa => 'Str', is => 'ro', required => 1);
has 'org_url' => (isa => 'Str', is => 'ro', required => 0);

@timlegge timlegge self-assigned this Feb 9, 2021
@timlegge timlegge added the bug Something isn't working label Feb 9, 2021
timlegge added a commit to timlegge/perl-Net-SAML2 that referenced this issue Feb 9, 2021
@timlegge timlegge added this to the 0.33-TRIAL milestone Feb 10, 2021
timlegge added a commit that referenced this issue Feb 10, 2021
Fixes #18 - SP metatdata org_url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant