Rename id to issuer for Net::SAML2::SP #202
Merged
+53
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timlegge
approved these changes
Feb 13, 2024
waterkip
force-pushed
the
GH-invalid-id_for_metadata_is_possible
branch
from
0def45a
to
cf28817
Compare
We've had generate_sp_desciptor_id to override the ID, but this could very well become a parameter for the constructor. The current ID attribute was actually used as the issuer. Rename ID to issuer and and reintroduce ID. We add some deprecation warnings to users so they are aware of the change. Signed-off-by: Wesley Schwengle <waterkip@cpan.org>
waterkip
force-pushed
the
GH-invalid-id_for_metadata_is_possible
branch
from
cf28817
to
c53ba9d
Compare
waterkip
changed the title
timlegge
reviewed
Feb 13, 2024
timlegge
requested changes
Feb 13, 2024
timlegge
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had generate_sp_desciptor_id to override the ID, but this could
very well become a parameter for the constructor. The current ID
attribute was actually used as the issuer. Rename ID to issuer and and
reintroduce ID. We add some deprecation warnings to users so they are
aware of the change.