Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "true" and "false" for more boolean values #225

Merged
merged 1 commit into from
May 21, 2024

Conversation

MartijnVdS
Copy link

Some IdPs (KPN) don't understand "1" and "0" as boolean values, but insist that the standard says only "true" or "false" are allowed.

A previous commit (bcfc4d2) already fixed several occurences, but it turned out there are more booleans hiding in the metadata XML.

Some IdPs (KPN) don't understand "1" and "0" as boolean values, but
insist that the standard says only "true" or "false" are allowed.

A previous commit (bcfc4d2) already fixed
several occurences, but it turned out there are more booleans hiding
in the metadata XML.
@waterkip
Copy link
Collaborator

KPN.. lgtm

@timlegge timlegge merged commit 9e84760 into perl-net-saml2:master May 21, 2024
4 checks passed
@MartijnVdS MartijnVdS deleted the wordy_bools branch May 22, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants