Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPERIMENT] our :unique $var #13171

Open
p5pRT opened this issue Aug 16, 2013 · 10 comments
Labels

Comments

@p5pRT
Copy link
Collaborator

@p5pRT p5pRT commented Aug 16, 2013

Migrated from rt.perl.org#119313 (status was 'open')

Searchable as RT119313$

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Aug 16, 2013

From @rjbs

perl 5.8.0 introduced the experimental reserved attribute :unique for use with
threading. It seems now to be universally unused and has been marked as
deprecated since perl 5.10.0.

We should rip it out.

I started to do this but found that there is code for it in threads, which is
upstream cpan. I described this earlier in​:

  http​://www.nntp.perl.org/group/perl.perl5.porters/2013/06/msg203084.html

Let's remove the code from perl and the perl core dist and turn it into just
another unknown attribute.

--
rjbs

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Aug 16, 2013

From @cpansprout

On Thu Aug 15 18​:07​:39 2013, rjbs wrote​:

perl 5.8.0 introduced the experimental reserved attribute :unique for
use with
threading. It seems now to be universally unused and has been marked
as
deprecated since perl 5.10.0.

We should rip it out.

I started to do this but found that there is code for it in threads,
which is
upstream cpan.

threads is in dist/ and Maintainers.PL says blead is upstream.

--

Father Chrysostomos

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Aug 16, 2013

The RT System itself - Status changed from 'new' to 'open'

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Aug 16, 2013

From @rjbs

On Fri Aug 16 05​:25​:21 2013, sprout wrote​:

threads is in dist/ and Maintainers.PL says blead is upstream.

I replied earlier, but it seems to have gone into the void.

I wrote​:

Yeah, I should've avoided the jargon. What I mean is that in practice, Jerry
has been working the other way around. Look at the history of dist/threads —
it's all imports from CPAN releases.

--
rjbs

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Aug 16, 2013

From @jdhedden

That is incorrect. Upstream is blead for threads and threads​::shared
releases. What usually happens is that I submit patches to blead
that say 'Upgrade to vXXX'. When that is accepted, I release to
CPAN.

On Fri, Aug 16, 2013 at 10​:24 AM, Ricardo SIGNES via RT
<perlbug-followup@​perl.org> wrote​:

On Fri Aug 16 05​:25​:21 2013, sprout wrote​:

threads is in dist/ and Maintainers.PL says blead is upstream.

I replied earlier, but it seems to have gone into the void.

I wrote​:

Yeah, I should've avoided the jargon. What I mean is that in practice, Jerry
has been working the other way around. Look at the history of dist/threads —
it's all imports from CPAN releases.

--
rjbs

---
via perlbug​: queue​: perl5 status​: open
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=119313

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Aug 16, 2013

From @jdhedden

I concur that :unique should be removed.

On Fri, Aug 16, 2013 at 10​:47 AM, Jerry D. Hedden <jdhedden@​gmail.com> wrote​:

That is incorrect. Upstream is blead for threads and threads​::shared
releases. What usually happens is that I submit patches to blead
that say 'Upgrade to vXXX'. When that is accepted, I release to
CPAN.

On Fri, Aug 16, 2013 at 10​:24 AM, Ricardo SIGNES via RT
<perlbug-followup@​perl.org> wrote​:

On Fri Aug 16 05​:25​:21 2013, sprout wrote​:

threads is in dist/ and Maintainers.PL says blead is upstream.

I replied earlier, but it seems to have gone into the void.

I wrote​:

Yeah, I should've avoided the jargon. What I mean is that in practice, Jerry
has been working the other way around. Look at the history of dist/threads —
it's all imports from CPAN releases.

--
rjbs

---
via perlbug​: queue​: perl5 status​: open
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=119313

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Aug 16, 2013

From @rjbs

On Fri Aug 16 07​:48​:15 2013, jdhedden@​gmail.com wrote​:

That is incorrect. Upstream is blead for threads and threads​::shared
releases. What usually happens is that I submit patches to blead
that say 'Upgrade to vXXX'. When that is accepted, I release to
CPAN.

Okay! Sorry I misunderstood. (I imagine you can see how I did. In large part, by not comparing
release dates to commit dates!)

I will update my branch to fully prune the feature and ask for a review.

--
rjbs

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Aug 17, 2013

From @rjbs

* Father Chrysostomos via RT <perlbug-followup@​perl.org> [2013-08-16T08​:25​:22]

I started to do this but found that there is code for it in threads, which
is upstream cpan.

threads is in dist/ and Maintainers.PL says blead is upstream.

Yeah, I should've avoided the jargon. What I mean is that in practice, Jerry
has been working the other way around. Look at the history of dist/threads —
it's all imports from CPAN releases.

--
rjbs

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Aug 19, 2013

From @Leont

On Fri, Aug 16, 2013 at 4​:47 PM, Jerry D. Hedden <jdhedden@​gmail.com> wrote​:

That is incorrect. Upstream is blead for threads and threads​::shared
releases. What usually happens is that I submit patches to blead
that say 'Upgrade to vXXX'. When that is accepted, I release to
CPAN.

To me that sounds like the workflow is more like upstream => cpan than
upstream =>blead, even if it technically isn't. Is there any reason not to
make cpan the upstream?

Leon

@p5pRT

This comment has been minimized.

Copy link
Collaborator Author

@p5pRT p5pRT commented Aug 19, 2013

From @cpansprout

On Mon Aug 19 05​:11​:34 2013, LeonT wrote​:

On Fri, Aug 16, 2013 at 4​:47 PM, Jerry D. Hedden <jdhedden@​gmail.com>
wrote​:

That is incorrect. Upstream is blead for threads and threads​::shared
releases. What usually happens is that I submit patches to blead
that say 'Upgrade to vXXX'. When that is accepted, I release to
CPAN.

To me that sounds like the workflow is more like upstream => cpan than
upstream =>blead, even if it technically isn't. Is there any reason not to
make cpan the upstream?

Yes, because it becomes an obstacle when bug-fixing necessitates
synchronised changes to the core and threads.xs at the same time.

--

Father Chrysostomos

@p5pRT p5pRT added the Severity Low label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.