Improvements for database handle and connection attributes #190
Conversation
It is enabled by default via CLIENT_FOUND_ROWS, so only clearing it is needed.
It is disabled by default, so only setting it is needed.
…e dbh By default it is turned off.
| return FALSE; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Again, what about testing?
There was a problem hiding this comment.
Fully automated testing of mariadb_auth_plugin is not possible. It requires configuration of different authentication method which would be understood by both client and server. Maybe it could be possible to write github CI testing for it, but that would require to change / hack how MySQL::Sandbox setup mysql server in its virtual env.
There was a problem hiding this comment.
Not even the mysql_native_password with a new client?
There was a problem hiding this comment.
We cannot expect that mysql_native_password is always present in new mysql versions (e.g. system admin can decide to not install support for it) and also we cannot expect that oracle does not decide to drop support for this specific plugin in some new mysql version. So automated test which is always run during install/test phase of perl DBD-MariaDB and uses mysql_native_password is fragile and can cause breaking of installation in future.
We can run such test only in controlled env, e.g. on github actions under configuration where we are sure that this one specific method mysql_native_password is enabled and is working.
|
Unfortunately new tests for So I would have to prepare different test for |
Since MySQL client version 5.5.7 it is possible to specify other authentication method than "mysql_native_password". This option can be used to specify authentication method which will client use during connection to MariaDB or MySQL server.
It is possible either via Makefile.PL option --testauthplugin or Makefile.PL env variable DBD_MARIABD_TESTAUTHPLUGIN.
Move documentation for mariadb_multi_statements, mariadb_server_prepare, and mariadb_server_prepare_disable_fallback from connection section to database handle section. And add information that any read/write dbh attribute can be specified also as connection parameter.
Sometimes git commit for pull requests on Github Actions CI is the fake merge commit, not the pushed one. So checkout the correct pushed (HEAD) commit.
|
Unfortunately I was not able to write any other reliable automated test for I squashed commits and dropped changes for non-working tests. |
$dbh->{mariadb_multi_statements}also after connection to server was establishedmariadb_auth_pluginconnection attribute