Fix allocating and releasing memory #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macro Newz() takes as third argument number of items in target array, not size of whole structure.
Use only Perl's alloc/free functions. Perl redefines C library alloc functions (malloc, realloc, free) to its own memory allocation and therefore it is not safe to use C library functions which allocate memory. Perl doesn't redefine calloc() so its usage is not safe as far as it allocates using C library memory management but frees with Perl's. See also: perl5-dbi#91
dongnguyenvt
reviewed
Oct 2, 2018
| "Initialize embedded server. Out of memory \n"); | ||
| return NULL; | ||
| } | ||
| Newz(908, options_list, cnt, char *); |
There was a problem hiding this comment.
one concern, so now it's just croak when OOM and not output anything to stream :)
There was a problem hiding this comment.
Yes, when there is no free memory, other memory allocations (in perl interpreter too; in DBI.xs too) would fail too.
dongnguyenvt
approved these changes
Oct 2, 2018
pali
added a commit
that referenced
this pull request
Oct 2, 2018
Fix allocating and releasing memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use only Perl's alloc/free functions. Perl redefines C library alloc
functions (malloc, realloc, free) to its own memory allocation and
therefore it is not safe to use C library functions which allocate memory.
Perl doesn't redefine calloc() so its usage is not safe as far as it
allocates using C library memory management but frees with Perl's.
See also: #91