perl.h:175:16: error: 'my_perl' undeclared

[rzl]

F:\perl\git\DBD-MariaDB-1.00\DBD-MariaDB-1.00>gmake
"F:\perl\Strawberry\perl\bin\perl.exe" -MExtUtils::Command::MM -e cp_nonempty -- MariaDB.bs blib\arch\auto\DBD\MariaDB\MariaDB.bs 644
gcc -c  -IF:\perl\Strawberry\perl\vendor\lib\auto\DBI -IF:\perl\STRAWB~1\c\bin\..\include\mysql50716 -DHAVE_DBI_1_634 -DHAVE_GET_OPTION -s -O2 -DWIN32
 -DWIN64 -DCONSERVATIVE -D__USE_MINGW_ANSI_STDIO -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -fwrapv -fno-strict-
aliasing -mms-bitfields -s -O2   -DVERSION=\"1.00\" -DXS_VERSION=\"1.00\"  "-IF:\perl\STRAWB~1\perl\lib\CORE"   dbdimp.c
In file included from F:\perl\Strawberry\perl\vendor\lib\auto\DBI/DBIXS.h:38:0,
                 from dbdimp.h:20,
                 from dbdimp.c:16:
F:\perl\Strawberry\perl\vendor\lib\auto\DBI/dbipport.h:4471:0: warning: "WIDEST_UTYPE" redefined
 #  define WIDEST_UTYPE U64TYPE

In file included from F:\perl\STRAWB~1\perl\lib\CORE/perl.h:2465:0,
                 from F:\perl\Strawberry\perl\vendor\lib\auto\DBI/DBIXS.h:23,
                 from dbdimp.h:20,
                 from dbdimp.c:16:
F:\perl\STRAWB~1\perl\lib\CORE/handy.h:1064:0: note: this is the location of the previous definition
 #   define WIDEST_UTYPE U64

In file included from F:\perl\Strawberry\perl\vendor\lib\auto\DBI/DBIXS.h:23:0,
                 from dbdimp.h:20,
                 from dbdimp.c:16:
dbdimp.c: In function 'free_embedded_options':
F:\perl\STRAWB~1\perl\lib\CORE/perl.h:175:16: error: 'my_perl' undeclared (first use in this function); did you mean 'my_bool'?
 #  define aTHX my_perl
                ^
F:\perl\STRAWB~1\perl\lib\CORE/embedvar.h:38:18: note: in expansion of macro 'aTHX'
 #    define vTHX aTHX
                  ^~~~
F:\perl\STRAWB~1\perl\lib\CORE/embedvar.h:55:19: note: in expansion of macro 'vTHX'
 #define PL_Mem   (vTHX->IMem)
                   ^~~~
F:\perl\STRAWB~1\perl\lib\CORE/iperlsys.h:816:4: note: in expansion of macro 'PL_Mem'
  (*PL_Mem->pFree)(PL_Mem, (buf))
    ^~~~~~
F:\perl\STRAWB~1\perl\lib\CORE/XSUB.h:613:19: note: in expansion of macro 'PerlMem_free'
 #    define free  PerlMem_free
                   ^~~~~~~~~~~~
dbdimp.c:548:7: note: in expansion of macro 'free'
       free(options_list[i]);
       ^
F:\perl\STRAWB~1\perl\lib\CORE/perl.h:175:16: note: each undeclared identifier is reported only once for each function it appears in
 #  define aTHX my_perl
                ^
F:\perl\STRAWB~1\perl\lib\CORE/embedvar.h:38:18: note: in expansion of macro 'aTHX'
 #    define vTHX aTHX
                  ^~~~
F:\perl\STRAWB~1\perl\lib\CORE/embedvar.h:55:19: note: in expansion of macro 'vTHX'
 #define PL_Mem   (vTHX->IMem)
                   ^~~~
F:\perl\STRAWB~1\perl\lib\CORE/iperlsys.h:816:4: note: in expansion of macro 'PL_Mem'
  (*PL_Mem->pFree)(PL_Mem, (buf))
    ^~~~~~
F:\perl\STRAWB~1\perl\lib\CORE/XSUB.h:613:19: note: in expansion of macro 'PerlMem_free'
 #    define free  PerlMem_free
                   ^~~~~~~~~~~~
dbdimp.c:548:7: note: in expansion of macro 'free'
       free(options_list[i]);
       ^
gmake: *** [Makefile:349: dbdimp.o] Error 1

F:\perl\git\DBD-MariaDB-1.00\DBD-MariaDB-1.00>perl -v

This is perl 5, version 28, subversion 0 (v5.28.0) built for MSWin32-x64-multi-thread

strawberry-perl-5.28.0.1-64bit.msi

[rzl]

i try to add dTHX to free_embedded_options function , gmake success

int free_embedded_options(char ** options_list, int options_count)
{
  int i;
  dTHX;
  for (i= 0; i < options_count; i++)
  {
    if (options_list[i])
      free(options_list[i]);
  }
  free(options_list);

  return 1;
}

[pali]

This is incorrect. Memory which is going to be freed by free() call in free_embedded_options is allocated in fill_out_embedded_options by calloc() call.

Perl headers file replaces malloc() and free() calls by own memory management. But does not replaces calloc() call.

On some systems those functions just calls system's malloc() and free() functions, therefore everything is safe. (Seems that all Linux machines which I tested). But error which you got on Windows indicates that it really has own memory management (needs that dTHX;) and calling Perl's free() on memory allocated by Windows native calloc() would for sure cause memory corruptions...

Correct way is to stop using calloc() and free() and uses Perl's Newz() and Safefree() replacment.

[rzl]

though I don't know what you are talking about, replace free to Safefree , gmake success.
thank you .

int free_embedded_options(char ** options_list, int options_count)
{
  int i;

  for (i= 0; i < options_count; i++)
  {
    if (options_list[i])
      Safefree(options_list[i]);
  }
  Safefree(options_list);

  return 1;
}

[pali]

though I don't know what you are talking about

That for allocation of memory calloc must be avoided and instead Newz should be used. And for releasing memory allocated by Newz should be used Safefree call.

[pali]

Will you prepare a proper fix for it?

[pali]

Patch for guarding calloc for perl itself is in following RT ticket: https://rt.perl.org/Public/Bug/Display.html?id=133550

[pali]

Ok, I did in in pull request #94. Please check.

[rzl]

Ok, I did in in pull request #94. Please check.

git clone https://github.com/pali/DBD-MariaDB.git
perl Makefile.PL --mysql_config=c:/path/mysql_config.bat
gmake
gmake install

success

[pali]

Ok, therefore it is fixed, closing.