Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm] global clean #507

Merged
merged 15 commits into from
Oct 10, 2018
Merged

[jvm] global clean #507

merged 15 commits into from
Oct 10, 2018

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Oct 9, 2018

I see the JVM backend is a bit messy and willing to do a global clean, make this pull request to listen if this is supported and run travis tests

@tisonkun
Copy link
Member Author

tisonkun commented Oct 9, 2018

travis fails on a missing return, would send a fix with next commit.

@tisonkun tisonkun merged commit 96714f3 into master Oct 10, 2018
@tisonkun tisonkun deleted the jvm-global-clean branch October 10, 2018 17:42
@tisonkun tisonkun changed the title [WIP] [jvm] global clean [jvm] global clean Oct 10, 2018
@jnthn
Copy link
Contributor

jnthn commented Oct 10, 2018

Does this achieve anything besides making git blame less useful and cluttering final all over the place on stuff that's effectively final anyway? :/

@tisonkun
Copy link
Member Author

tisonkun commented Oct 11, 2018

For the former, yes, I mix up layout adjustment and code refactor. They should have been two topic. Sorry.
For the latter, it is a code style thing. Whether place final to guard variables are intended to be final, or, use effectively final semantic, save the final word and confirm a variable is final by analyze.

ugexe added a commit that referenced this pull request Oct 21, 2018
@AlexDaniel
Copy link
Member

@tisonkun your commits were reverted here: rakudo/rakudo#2406 (comment)

Please take a look and see if they can be reintroduced again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants