Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Issue 1204 (Strip slip in quotewords) #373

Merged
merged 1 commit into from Dec 31, 2017
Merged

Test Issue 1204 (Strip slip in quotewords) #373

merged 1 commit into from Dec 31, 2017

Conversation

jstuder-gh
Copy link
Contributor

This tests for bugs exhibited in
Issue 1204.

Corresponds with development in Rakudo:
Commit ad684de383bb0c0ff051d7b0901583a9b5c2e398
PR 1350

This does not provide cover every variation of the quoting syntax, but
hopefully provides sufficient coverage.

@jstuder-gh
Test Issue 1204 (Strip slip in quotewords)
4788582 
This tests for bugs exhibited in
[Issue 1204](rakudo/rakudo#1204).

Corresponds with development in Rakudo:
    Commit ad684de
    [PR 1350](rakudo/rakudo#1350)
@zoffixznet zoffixznet merged commit bb44171 into Raku:master Dec 31, 2017
@zoffixznet
Copy link
Contributor

zoffixznet commented Dec 31, 2017 •
edited

👍 Thanks!

For record, is « "$x" », '5 6', doesn't test whether return value is a single string. It could return (5, 6) and the test would still pass, because is routine stringifies. The is routine is almost always a wrong tool for the job.

The is-deeply routine should be used (I already changed it in 22f00c7 )

@jstuder-gh
Copy link
Contributor Author

Oh I didn't know that. I'll keep that in mind for the next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jstuder-gh @zoffixznet