Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S16 io eof wsl script fudge #397

Merged
merged 2 commits into from Mar 10, 2018
Merged

S16 io eof wsl script fudge #397

merged 2 commits into from Mar 10, 2018

Conversation

ronaldxs
Copy link
Contributor

See issue #395. Since we change Test::Util run-with-tty we also effect S32-io/out-buffering.t as well as S16-io/eof.t. On WSL/ubuntu 16 out-buffering.t also breaks the terminal but it ran OK on WSL ubuntu 14 since, unlike eof.t, the script process did not read from stdin. Having the out-buffering.t test run on ubuntu 14 does not seem FTM worth a more complicated patch.

@zoffixznet zoffixznet merged commit 1154bc6 into Raku:master Mar 10, 2018
@zoffixznet
Copy link
Contributor

zoffixznet commented Mar 10, 2018

👍 Thanks!

If there are any more WSL detections that'd need to be made in roast, we should think about adding some is-OS-WSL utility routine to Test::Util instead of having a long line with $*DISTRO and $*KERNEL each time (or, if there's enough demand, some easier way to detect WSL in Rakudo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants