New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds test for translate-nl #462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should tests for "a\nb"
be included as well?
@Kaiepi well, it was not tested, so while I was on the file I decided to include that too. |
These tests are broken. You're testing the literal Also, please use |
Ok
El mié., 8 ago. 2018 12:59, Zoffix Znet <notifications@github.com> escribió:
… These tests are broken. You're testing the literal \ and n instead of the
actual newline characters and the non-Windows branch is missing
:translate-nl argument.
Also, please use is-deeply routine instead of ok, so failures would
actual show the differences between expected and got versions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#462 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAB9MV403HiFCDEfOcA_x2oMmtNvq9sks5uOsSRgaJpZM4VzcJG>
.
|
👍 Thanks! |
Thanks for reviewing and spotting the errors :-)
|
And some reasonable additional tests.