Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test for translate-nl #462

Merged
merged 5 commits into from Aug 8, 2018
Merged

Adds test for translate-nl #462

merged 5 commits into from Aug 8, 2018

Conversation

JJ
Copy link
Contributor

@JJ JJ commented Aug 8, 2018

And some reasonable additional tests.

JJ added 3 commits August 7, 2018 18:50
Working on Raku#459, getting the lay of the land first.
Since that option is only available in Windows, I have added that test
with the optional code. Closes Raku#459
@JJ JJ requested a review from Kaiepi August 8, 2018 07:47
Copy link
Contributor

@Kaiepi Kaiepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should tests for "a\nb" be included as well?

@JJ
Copy link
Contributor Author

JJ commented Aug 8, 2018

@Kaiepi well, it was not tested, so while I was on the file I decided to include that too.

@zoffixznet
Copy link
Contributor

These tests are broken. You're testing the literal \ and n instead of the actual newline characters and the non-Windows branch is missing :translate-nl argument.

Also, please use is-deeply routine instead of ok, so failures would actual show the differences between expected and got versions.

@JJ
Copy link
Contributor Author

JJ commented Aug 8, 2018 via email

@zoffixznet zoffixznet merged commit d422889 into Raku:master Aug 8, 2018
@zoffixznet
Copy link
Contributor

👍 Thanks!

@JJ
Copy link
Contributor Author

JJ commented Aug 8, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants