Test for GH 2684 (questions) #542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of things I am not really sure about in this test, can someone, please, answer the following?
1)Description of
make-tmp-dirsays that the end-user must clean up created files beforehand, see #384 ticket. But the previous test in this file does not seem to do any cleanup, so I didn't add it too. Should both tests be fixed? Or maybe we have to do something with the ticket? If yes, how can I help? To changermdirintorm -rfequivalent and run spectest seeing if anything broke?2)It seems that this issue did not end up in a release... I tried the test on both 2018.12 and 2019.03 and it just passes... But ultimately I am not sure if it passes because the test is correct and the bug is fixed already(and on 2018.12 it was not yet introduced) or it is just a broken test. Possibly I can roll back to the commit before the fix, but what to do with two dependent repos, moarvm and nqp, just search their respective commits of that time?
Issue link -> rakudo/rakudo#2684