Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for auto-generated private accessors. #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

autark
Copy link

@autark autark commented Jan 5, 2016

No description provided.

@AlexDaniel
Copy link
Member

I am half way through reviewing this PR. However, I don't understand why the test for RT #125227 is removed. Could you shine a light on that?

That being said, this removed test seems to be wrong. $o ~~ /':2'/ will probably match World.nqp:2498 just as well.

@autark
Copy link
Author

autark commented Feb 9, 2016

These tests are written in support of PR rakudo/rakudo#674. That PR adds support for auto-generating private accessors, it also attaches defined semantics to 'is rw'/'is readonly' for private attributes. In that regard the test was removed as it specifically tests that 'is rw' will generate a warning -- something it should no longer do.

@JJ
Copy link
Contributor

JJ commented May 6, 2020

This issue mentions an issue that has been closed as Rejected, and also has a good amount of conflicts. Closing it.

@JJ JJ closed this May 6, 2020
@AlexDaniel
Copy link
Member

AlexDaniel commented May 6, 2020

What? This is a PR with tests for rakudo/rakudo#674 which is open. So this should be open as well.

@AlexDaniel AlexDaniel reopened this May 6, 2020
@vrurg
Copy link
Contributor

vrurg commented May 6, 2020

Worth a problem-solving issue, I'd say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants