Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perl 5 porter archive links #152

Closed
wants to merge 1 commit into from
Closed

Fix perl 5 porter archive links #152

wants to merge 1 commit into from

Conversation

starkej2
Copy link
Contributor

@starkej2 starkej2 commented Oct 3, 2018

Resolves #128 by replacing dead links pointing to www.xray.mpe.mpg.de with links to https://www.nntp.perl.org/.

Copy link
Contributor

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new links aren't correct. The messages with the same number don't correspond in the two repositories. In my spot check I didn't find a single new link that related to its context.

@starkej2
Copy link
Contributor Author

starkej2 commented Oct 3, 2018

👍 I only checked a few of them and they looked correct, but I'll take a look!

@briandfoy
Copy link
Contributor

Let's start over on this pull request. Submit a PR for only _content/legacy/pub_1999_10_p5pdigest_THISWEEK-19991017.md - that's a link to just the mailing list repo as a whole and that's a good change. That gets you the Hacktoberfest credit. From that we can work on the other files individually as we verify them by hand.

Thanks!

@briandfoy briandfoy closed this Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants