Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid running tests with old Perls on new systems #1
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
HaraldJoerg commentedOct 18, 2018
CPAN Testers report errors in the test suite for old Perl versions: http://www.cpantesters.org/distro/O/Org-To-HTML.html
The root cause is that old Perl versions' "use locale" (as in Org::Document) doesn't play well with current systems which have UTF-8-based locales, so actually it is the parser which fails and not the converter. The converter should simply skip the tests on old versions because I'd guess it is safe to assume that these old Perl versions are only in use on older operating systems - where the parser works quite fine.