(interpreter) Move away from relying on dynamic for unary prefix/postfix operators
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
commented
Nov 16, 2021
perlun
commented
Nov 16, 2021
perlun
commented
Nov 16, 2021
perlun
commented
Nov 16, 2021
perlun
commented
Nov 16, 2021
| @@ -356,6 +356,9 @@ private void Number() | |||
|
|
|||
| if (isFractional) | |||
| { | |||
| // TODO: This is a mess. We currently treat all floating point values as _double_, which is insane. We | |||
| // TODO: should probably have a "use smallest possible type" logic as below for integers, for flotaing point | |||
| // TODO: values as well. We could also consider supporting `decimal` while we're at it. | |||
There was a problem hiding this comment.
See #70. I think that adding an explicit float and double should get fairly high priority, since the current way (of just putting everything in there as doubles) is extremely messed up, to be honest.
perlun
force-pushed
the
refactor/remove-usage-of-dynamic-keyword
branch
from
6d98be2
to
70fe601
Compare
perlun
force-pushed
the
refactor/remove-usage-of-dynamic-keyword
branch
from
70fe601
to
65980c7
Compare
perlun
changed the title
perlun
changed the title
perlun
force-pushed
the
refactor/remove-usage-of-dynamic-keyword
branch
from
65980c7
to
52f3dca
Compare
perlun
added a commit
that referenced
this pull request
Nov 19, 2021
While working on #227, I noted that there are many different permutations of operations (>, <, <=, >= and so forth) and types where we only had test coverage of the int + int scenarios. It's much better to try and (as far as is reasonably possible) cover all supported combinations of types, especially if/when we start handling these manually instead of letting dynamic work it out for us.
perlun
changed the title
dynamic for unary prefix/postfix operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards resolving #225. The MR fixes the
-unary prefix and the--/++postfix operators to manually handle all types instead.