(all) Support int literals in addition to doubles
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I decided to use `dynamic` to implement this for now. It's the simplest way to not having to handle all various combinations of integer types manually. Doing it like this made it quite easy in the end, it felt impossible just some day ago. :) As for how to handle integer literals, I decided to with the same rules are C# applies for now. > If the literal has no suffix, its type is the first of the following > types in which its value can be represented: int, uint, long, ulong. (quoting https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/builtin-types/integral-numeric-types) The suffix stuff is not supported at the moment; we provide no way to explicitly specify neither `ulong`, `uint` or `double`. This will probably have to fixed at some point, but just supporting various integer types and `double` is probably a good start. (We could do the same for the floating point values btw, to coerce them into `float` if the encountered floating point literal is small enough.)
perlun
changed the title
int literals in addition to doubles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to use
dynamicto implement this for now. It's the simplest way to not having to handle all various combinations of integer types manually.Doing it like this made it quite easy in the end, it felt impossible just some day ago. :)
As for how to handle integer literals, I decided to with the same rules are C# applies for now.
(quoting https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/builtin-types/integral-numeric-types)
The suffix stuff is not supported at the moment; we provide no way to explicitly specify neither
ulong,uintordouble. This will probably have to fixed at some point, but just supporting various integer types anddoubleis probably a good start. (We could do the same for the floating point values btw, to coerce them intofloatifthe encountered floating point literal is small enough.)