(stdlib) Wrap ASCIIString in std::shared_ptr<T>
#453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
added
stdlib
perlun
changed the title
ASCIIString improvementsASCIIString in std::shared_ptr<T>
* `ASCIIString` and `String` are now wrapped in a `std::shared_ptr<T>` container, which means that we can fix a bunch of the skipped tests mentioned in #451. * This makes it possible to assign an `ASCIIString` to an (abstract) `String`. Impossible with non-pointers, because it involves the C++ copy operator, so this is a benefit of the above.
perlun
force-pushed
the
fix/AsciiString-to-String-assignment
branch
from
3f447fc
to
f1ff5a1
Compare
perlun
force-pushed
the
fix/AsciiString-to-String-assignment
branch
from
f1ff5a1
to
a4be9d0
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASCIIStringandStringare now wrapped in astd::shared_ptr<T>container, which means that we can fix a bunch of the skipped tests mentioned in (stdlib) Implement initial nativeASCIIStringclass #451.This makes it possible to assign an
ASCIIStringto an (abstract)String. Impossible with non-pointers, because it involves the C++ copy operator, so this is a benefit of the above.