(tests) Implement more EvalHelper methods for compiled mode
#463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
added
tests
perlun
added a commit
that referenced
this pull request
Apr 23, 2024
This has been an oversight while working on the experimental Perlang compiler (#406). The bug was discovered when implementing the changes in #463; when we started running one of those tests, no error was emitted even though the code was redefining a top-level function. It turned out that the compiler would silently overwrite a function if you defined it twice.
perlun
added a commit
that referenced
this pull request
Apr 23, 2024
This has been an oversight while working on the experimental Perlang compiler (#406). The bug was discovered when implementing the changes in #463; when we started running one of those tests, no error was emitted even though the code was redefining a top-level function. It turned out that the compiler would silently overwrite a function if you defined it twice.
|
Failed in CI as expected, because we need the fix in #464 to make this work. |
perlun
added a commit
that referenced
this pull request
Apr 23, 2024
This has been an oversight while working on the experimental Perlang compiler (#406). The bug was discovered when implementing the changes in #463; when we started running one of those tests, no error was emitted even though the code was redefining a top-level function. It turned out that the compiler would silently overwrite a function if you defined it twice.
perlun
force-pushed
the
test/support-EvalHelper-methods-in-compiled-mode
branch
from
0314e01
to
ab0f836
Compare
This is a preparation for removing interpreted mode completely, expected to follow shortly.
perlun
force-pushed
the
test/support-EvalHelper-methods-in-compiled-mode
branch
from
ab0f836
to
383395c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for removing interpreted mode completely, expected to follow shortly.