(many) Support more types in string+int and int+string concatenation #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
added
stdlib
perlun
commented
May 7, 2024
| rightTypeReference.ClrType == typeof(AsciiString))) { | ||
| // 42 + "string" + 42 | ||
| expr.TypeReference.ClrType = typeof(AsciiString); | ||
| } | ||
| else if (expr.Operator.Type == TokenType.PLUS && | ||
| (leftTypeReference.ClrType == typeof(int) && | ||
| (new[] { typeof(int), typeof(long), typeof(uint), typeof(ulong) }.Contains(typeof(int)) && |
There was a problem hiding this comment.
Hmm, these three are quite obviously wrong. 😁 Let's see if we have a test that covers this error of mine... 🙈
There was a problem hiding this comment.
I think we do, in fact. The [Internal compiler error](error: no viable conversion from 'shared_ptr)` problem is probably caused by this, triggering a different code path, making a previously skipped test no longer be skipped... and that test in turn is currently broken, since it generates C++ code which looks like this:
std::shared_ptr<const perlang::ASCIIString> a = perlang::ASCIIString::from_static_string("a");
perlang::print(a);
std::shared_ptr<const perlang::ASCIIString> b = (*a + *perlang::ASCIIString::from_static_string(" b"));
perlang::print(b);
std::shared_ptr<const perlang::ASCIIString> c = (*a + *perlang::ASCIIString::from_static_string(" c"));
perlang::print(c);
std::shared_ptr<const perlang::ASCIIString> d = (*b + *perlang::ASCIIString::from_static_string(" d"));
perlang::print(d);This fails because some of these + operators return a std::shared_ptr<const perlang::String>, which can't be converted to std::shared_ptr<const perlang::ASCIIString>. We'll have to look into this at some point, but not tonight...
perlun
force-pushed
the
feature/string-and-unsigned-int-concatenation
branch
from
48e684d
to
ac29a54
Compare
perlun
force-pushed
the
feature/string-and-unsigned-int-concatenation
branch
from
ac29a54
to
c63fda4
Compare
...and remove some commented out code that was merged by mistake in #462.
perlun
force-pushed
the
feature/string-and-unsigned-int-concatenation
branch
from
c63fda4
to
321f94d
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.