Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update topology.js and dijkstra.js #69

Closed
wants to merge 2 commits into from

Conversation

eric183
Copy link

@eric183 eric183 commented Aug 27, 2020

https://codesandbox.io/s/8y2f7?file=/src/index.js

Here's the sandbox reappearing this error

require default module BUG fixed
require default module BUG fixed
@perliedman
Copy link
Owner

This is an ongoing problem when you bundle with Webpack (which I guess is where you encounter this?), see for example webpack/webpack#4742. Applying your fix will unfortunately break the module for anyone not using Webpack, which is not acceptable.

I would be happy to make changes to for example package.json to work around this if possible, but fiddling with normal, working CommonJS requires simply is not something I think I should be responsible for as a module maintainer.

@perliedman perliedman closed this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants