Ledger state syncing / pull missing transactions - minor cleanup and improvements. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve peers to pull tx from, minor fixes to vote
a-urth
changed the title
|
@losfair cleaned up code from comments and prints, added description to what was actually done within this PR. |
|
@losfair or @iwasaki-kenta if its ok can we please merge it? since there are some changes in here which i want to use in order to test syncing fix in other branch? |
iwasaki-kenta
approved these changes
Jul 17, 2019
iwasaki-kenta
changed the title
Looks good, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop pulling missing transactions in case state sync needs to be done immediately instead of waiting for now more missing transaction
Lower most of syncing related timeouts - pulling, querying etc
Add check for live connections in most places - before pulling and for
SelectPeersChange how gossip network part works - do not store streams, create new stream each time instead and just pass in case of error - it avoid problem using "dead" connection and connection which were not removed from map. And since we send transactions in batch overhead of creating new connection is not that big.