Prefer values over heap-allocated values, simplify memory model, and fix appending parent transaction seeds to transactions. #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… original memory alloc model such that values are emphasized over pointers to ensure correctness tx: fix AttachSenderToTransaction to properly sort and index parent seeds with respect to index locations of parent ids tests: parallelize tests where possible
iwasaki-kenta
added
bug
a-urth
reviewed
Jul 18, 2019
tx.go
Outdated
| } | ||
|
|
||
| func (t *Transaction) rehash() { | ||
| func (tx *Transaction) rehash() *Transaction { |
There was a problem hiding this comment.
why this still returns pointer? since its method of transaction struct itself i guess it can mutate. otherwise it needs to return value.
There was a problem hiding this comment.
True, will remove that.
a-urth
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api, cmd/wavelet, gossip, collapse, genesis, ledger, round: revert to original memory alloc model such that values are emphasized over pointers to ensure correctness
tx: fix AttachSenderToTransaction to properly sort and index parent seeds with respect to index locations of parent ids
tests: parallelize tests where possible