Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting log level via cli parameters #229

Merged
merged 4 commits into from Sep 27, 2019
Merged

Allow setting log level via cli parameters #229

merged 4 commits into from Sep 27, 2019

Conversation

hasyimibhar
Copy link
Contributor

Refer to #212. This PR adds -loglevel cli param, which overrides the log level for all loggers in the log package.

@hasyimibhar hasyimibhar self-assigned this Sep 19, 2019
rkeene
rkeene approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@rkeene rkeene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rkeene rkeene merged commit 5700132 into master Sep 27, 2019
@rkeene rkeene mentioned this pull request Oct 1, 2019
Closed
@iwasaki-kenta iwasaki-kenta deleted the logging-cli branch October 17, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkeene rkeene rkeene approved these changes

Assignees

@hasyimibhar hasyimibhar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hasyimibhar @rkeene