Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It could use more of Moo #14

Open
dakkar opened this issue Dec 29, 2016 · 2 comments
Open

It could use more of Moo #14

dakkar opened this issue Dec 29, 2016 · 2 comments

Comments

@dakkar
Copy link

dakkar commented Dec 29, 2016

Looking at the source code, I notice that in a few places you're not exploiting the facilities that Moo provides (e.g. you've got common and build do more-or-less what BUILDARGS and BUILD are designed to do, you handle lazy attributes by hand, you have no type constraints).
Is there a particular reason for that, or is just general unfamiliarity with Moo?
Would it be appreciated if I sent a pull request making the whole thing more Moo-ish? I'd also like to add some type constraints via Type::Tiny, but that can come later.

@perlpunk
Copy link
Owner

yeah, i'm not familiar enough with Moo and did it the old school manual way so far.
I have been refactoring a lot and I hope I have to do less in the future. Would be glad about a PR!
I also wanted to add type constraints someday =)

@dakkar
Copy link
Author

dakkar commented Dec 29, 2016

I'll get started, then ☺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants