Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposed changes to use more of Moo #15

Closed
wants to merge 15 commits into from
Closed

proposed changes to use more of Moo #15

wants to merge 15 commits into from

Conversation

dakkar
Copy link

@dakkar dakkar commented Dec 30, 2016

In reference to #14, here's a few changes:

  • type constraints everywhere: among other things, this makes clearer what each attribute can accept
  • defaults for all attributes where it makes sense
  • BUILDARGS/new instead of common/build, this makes classes easier to use and extend
  • op now canonically accepts a coderef (previously it did, but probably by mistake: it's a useful feature, let's support it properly)

Needed before merging:

  • documentation for all the type constraints
  • better names for them

Possible future work:

  • review the various enums
  • review the various union types, and check if they really make sense
  • reduce the number of rw attributes

@dakkar
some type constraints
6a5f587
@dakkar
more correct complex types
9956fbf
@dakkar
::Run::Output can be anything, not just a string
4075d3b
@dakkar
type constraints for ::Run::Response
909d957 
I'm assuming that the `->callbacks([])` in the test was a mistype
@dakkar
types for ::Role::Command
f0630a5 
Interesting detail: if the main spec does not declare subcommands, the
various plugins' ->install_subcommands will be invoked, but will not
have any effect

I suspect this is a bug.
@dakkar
rename types for better clarity
fc0413e
@dakkar
type constraint in ::Pod
59e22db
@dakkar
type constraints in ::Run::Validator
f015a29
@dakkar
type constraints for ::Spec
29b0dba
@dakkar
CommandOp type
3a26411 
an op can be either a method name, or a coderef to be invoked as a
method
@dakkar
types for ::Run
bf50b4e
@dakkar
use BUILDARGS/new instead of common/build
ec819f4
@dakkar
simpler ::Argument buildargs
056d17c
@dakkar
simpler plugin handling in ::Command
7bd67ed
@dakkar
tweaks from external tests
6d10ca1
@perlpunk
Copy link
Owner

wow, that's a lot to review! I'll do that next year ;-)
thanks so far

@perlpunk
Copy link
Owner

perlpunk commented May 1, 2017

i'm really sorry that i haven't had time for this so far =(
i'm very busy with the YAML project currently, hope it will get better end of may

@dakkar dakkar mentioned this pull request Dec 26, 2017
Open
@dakkar
Copy link
Author

dakkar commented Dec 26, 2017

closing this in favour of #17

@dakkar dakkar closed this Dec 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dakkar @perlpunk