Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and improve code #81

Merged
merged 31 commits into from
Aug 30, 2022
Merged

Refactor and improve code #81

merged 31 commits into from
Aug 30, 2022

Conversation

itsnebulalol
Copy link
Member

Description
In this PR, @superrnovae refractored and improved a lot of the code.

  • Rewritten code
  • Merged files
  • Code improvements
  • More fixes

@superrnovae
Rewrite and document the utility class
bd17d25
@superrnovae
Split main module into relatively small methods and document everything
aad2989
@superrnovae
Make main.py executable again
0dcaf04
@superrnovae
Merge branch 'main' of github.com:itsnebulalol/permasigner into comments
ce39e94
@superrnovae
Remove constrictor's control module
6adf838
@superrnovae
previous approach is better
9a6e3b6
@superrnovae
use pathlib in setup file
57b58df
@superrnovae
fix version output when in/out of package
f0f667d
@superrnovae
switch back to gnu format for tarfile
b361752
@superrnovae
move except block to where it was before
d5232fc
@superrnovae
use fstrings in logger to fix exception printing
dcc6b4d
@superrnovae
rename modules and move methodes around
a5e8b7d
@superrnovae
Merge branch 'main' of github.com:itsnebulalol/permasigner into refactor
9d71c01
@superrnovae
Make the output prettier
6b3bb06
@superrnovae
relative imports
92e501a
@superrnovae
rename modules
af3a35b
@superrnovae
Remove unused attribute
a4358c3
@superrnovae
revert the rename of modules
4737408
@superrnovae
Rewrite tmp cleanup
b3a932b
@superrnovae
fix download and extract methods
4b3469c
@superrnovae
bundle unix-ar and rewrite extraction
0919566
@superrnovae
add unix-ars license file
345bba3
@superrnovae
remove unix-ar req, we're bundling it
190f215
@superrnovae
Add context manager to arfile
fef11ba
@superrnovae
remove walruses
289c3ff
@superrnovae
fix version output
7a6deeb
@superrnovae
return output arg as path
169e283
@superrnovae
pass path to bundle as an fstring
db65230
@superrnovae
pass path to ldid as fstring
8dd04eb
@superrnovae
set chmod +x instead of chmod 755
e1a4c2b
@itsnebulalol itsnebulalol merged commit 75c854f into main Aug 30, 2022
@itsnebulalol itsnebulalol deleted the refactor branch August 30, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itsnebulalol @superrnovae