Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cred and quests zh translate and fix zh testnet-info path error #165

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

HelloRWA
Copy link
Contributor

No description provided.

@HelloRWA HelloRWA changed the title feat: add cred and quests zh translate and fix testnet-info path error feat: add cred and quests zh translate and fix zh testnet-info path error Mar 21, 2024
@PSkinnerTech
Copy link
Collaborator

Hey @HelloRWA!

Is this still a work in progress, or is ready to be reviewed?

If this is still a work in progress, can you add [WIP] to the beginning of the PR title?

When it's ready for review, can you tag me as a requested reviewer?

Thanks!

@HelloRWA
Copy link
Contributor Author

Hey @HelloRWA!

Is this still a work in progress, or is ready to be reviewed?

If this is still a work in progress, can you add [WIP] to the beginning of the PR title?

When it's ready for review, can you tag me as a requested reviewer?

Thanks!

Hi @PSkinnerTech
Ya! it's already done, wait for the review!
Next time I will directly tag you as a requested reviewer! I believed I will make more PR on ao/aos/cookbook projects ;)

@PSkinnerTech
Copy link
Collaborator

Hey @HelloRWA, can you resolve the conflicts so that I can merge?

@PSkinnerTech
Copy link
Collaborator

Fixed the conflicts and merging.

@PSkinnerTech PSkinnerTech merged commit 1839048 into permaweb:main Apr 12, 2024
2 checks passed
@TillaTheHun0 TillaTheHun0 linked an issue May 3, 2024 that may be closed by this pull request
@TillaTheHun0 TillaTheHun0 mentioned this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is it a sh or lua?
2 participants