Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support maxSdkVersion #204

Merged
merged 5 commits into from Sep 25, 2016
Merged

Support maxSdkVersion #204

merged 5 commits into from Sep 25, 2016

Conversation

hotchemi
Copy link
Member

@hotchemi hotchemi commented Sep 24, 2016 •
edited

ref: #192
ref: https://developer.android.com/guide/topics/manifest/uses-permission-element.html

Change

  • Add maxSdkVersionSupport.
    • Add maxSdkVersion in NeedsPermission.java
    • If specified value is above 0, processor creates code that only checks SDK_INT and call needs permission method.
    • If specified value is 0 or below, it does nothing.

@hotchemi hotchemi changed the title [WIP] Support maxSdkVersion. Support maxSdkVersion. Sep 25, 2016
@hotchemi hotchemi changed the title Support maxSdkVersion. Support maxSdkVersion Sep 25, 2016
@hotchemi
Copy link
Member Author

@shiraji @aurae Can you take a look and merge?

@hotchemi hotchemi merged commit a03bf73 into master Sep 25, 2016
@hotchemi hotchemi deleted the issue192 branch September 25, 2016 05:33
@hotchemi
Copy link
Member Author

Let me merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hotchemi