Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Lint Rules to UAST #363

Merged
merged 8 commits into from Sep 11, 2017
Merged

Migrate Lint Rules to UAST #363

merged 8 commits into from Sep 11, 2017

Conversation

hotchemi
Copy link
Member

@hotchemi hotchemi commented Sep 9, 2017

Issue

Overview

  • Migrate Lint Rules to use UAST from PSI
    • To work with both Java/Kotlin! Check the forum post to get more detail
    • Currently there's no document about that except Tor's post on group 馃樋
  • Fix test cases not to use old LintDetectorTest which is JUnit3 based one.
  • Update gradle to 4.1, android-gradle-plugin to 3.0.0-beta5, Kotlin to 1.1.3-2
  • Fix lint checks

This was referenced Sep 9, 2017
@hotchemi hotchemi changed the title [WIP] Migration Lint API to UAST from PSI Migrate Lint Rules to UAST Sep 10, 2017
@hotchemi
Copy link
Member Author

@permissions-dispatcher/committers please review 馃檱

@hotchemi
Copy link
Member Author

Let me merge this PR since it includes some significant changes to proceed other task 馃檱
If there's weird points let me know 馃檱

@hotchemi hotchemi merged commit 9e78d03 into master Sep 11, 2017
@hotchemi hotchemi deleted the lint-uast branch September 11, 2017 08:30
@mannodermaus
Copy link
Contributor

I was only able to read over the changes superficially, but everything looks good to me from here. Thank you for the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Lint Rules to UAST
2 participants