Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CallNeedsPermissionDetector #368

Merged
merged 2 commits into from Sep 15, 2017
Merged

Fix CallNeedsPermissionDetector #368

merged 2 commits into from Sep 15, 2017

Conversation

hotchemi
Copy link
Member

Issue

  • None

Overview

  • I found that CallNeedsPermissionDetector lint check hasn't been working since around 2.2.0... 馃槩
    • The reason is basically somehow we missed these logics which actually detect illegal method call.
    • Actually unit test cases were weird and that's why we couldn't notice that.
  • So I fixed both the logic itself and test case.

@shiraji shiraji merged commit a9c1c1e into master Sep 15, 2017
@hotchemi hotchemi deleted the fix_lint branch September 15, 2017 13:05
@hotchemi hotchemi mentioned this pull request Oct 11, 2017
Closed
mannodermaus added a commit to mannodermaus/PermissionsDispatcher that referenced this pull request Oct 18, 2017
@mannodermaus
Use identical test foundation for both Uast & Psi implementation
b668f29 
Use @parameterized tests to check all implementations of our Lint checks.
At the moment, the older Psi implementation doesn't pass the revised
logic of some tests yet, because of recent bug fixes like permissions-dispatcher#368.
Therefore, this is a WIP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiraji shiraji Awaiting requested review from shiraji

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hotchemi @shiraji