Add kotlin test cases for lint module #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweak CallOnRequestPermissionsResultDetector to address onRequestPermissionsResult extension function.
hotchemi
commented
Apr 15, 2018
| private OnRequestPermissionsResultChecker(JavaContext context, UClass klass) { | ||
| this.context = context; | ||
| this.className = klass.getName(); | ||
| isKotlin = context.getPsiFile() != null && "kotlin".equals(context.getPsiFile().getLanguage().getID()); |
There was a problem hiding this comment.
@shiraji I guess we can detect the file is kotlin or not as this!
There was a problem hiding this comment.
Does getLanguage() return an enum that already contains a Kotlin member? If so, and we have access to that, might as well use that
There was a problem hiding this comment.
Thank you! Actually Language is not an Enum but just an abstract class.. 😅A bit unsmart but we gotta check ID 🤔
https://github.com/JetBrains/intellij-community/blob/571fbe96754e6c762fe8f7f8532ae2665bfbae61/platform/core-api/src/com/intellij/lang/Language.java#L42
|
Can I merge? |
|
Sure! |
shiraji
approved these changes
Apr 16, 2018
|
Thank you guys! I'll release next version tonight! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
resolves #373
Overview