android x support #494

shiraji · 2018-06-26T00:59:11Z

See #488

~~We need to wait bintray support gradle 4.6 or release this alpha version manually ✋~~

TODO

Support androidx
Drop support v4
Handle the problem with bintray-release

NOT TODO for this PR

Drop native fragment support

shiraji · 2018-06-26T01:40:27Z

It seems dropping native fragment support makes diff huge. Do you guys want me to split PR? @hotchemi @mannodermaus

hotchemi · 2018-06-26T01:42:46Z

yea it's better I guess!

shiraji · 2018-06-26T01:51:45Z

I will create new PR for these commits.

f745322
cb7d58b
edd66c4

shiraji · 2018-06-26T02:05:28Z

Ah, one more thing, do you want me to send PR for non-master branch like version-4 or somthing?

hotchemi · 2018-06-26T02:37:04Z

To master is ok! But to merge this PR we need to deal with bintray-release plugin.. 🤔

adopted processors to honour new AndroidX package names

my android studio was in a corrupt state and showed me a running app and tests...

shiraji · 2018-06-26T20:43:08Z

.travis.yml

- echo "sdk.dir=$ANDROID_HOME" > local.properties
+  - echo "sdk.dir=$ANDROID_HOME" > local.properties
+  - mkdir "$ANDROID_HOME/licenses" || true
+  - cp ./android-sdk-licenses/* "$ANDROID_HOME/licenses/"


We might not need this change because of bintray-release plugin

shiraji · 2018-06-26T20:43:26Z

gradle.properties

 MIN_SDK_VERSION         = 14

 # Gradle parameters
 org.gradle.daemon       = true
 org.gradle.jvmargs      = -XX:MaxPermSize=1024m -XX:+CMSClassUnloadingEnabled -XX:+HeapDumpOnOutOfMemoryError -Xmx2048m
+android.useAndroidX=true
+android.enableJetifier=true


shiraji · 2018-06-26T20:44:12Z

lint/src/test/java/permissions/dispatcher/CallOnRequestPermissionsResultDetectorTest.kt

@@ -9,6 +9,7 @@ import permissions.dispatcher.Utils.onNeedsPermission
 import permissions.dispatcher.Utils.onRationaleAnnotation
 import permissions.dispatcher.Utils.runtimePermission

+


What's this?

shiraji · 2018-06-26T21:35:21Z

we need to deal with bintray-release plugin

3 options I came up:

Wait until bintray-release plugin support gradle 4.6
Manual upload 😉
Migrate to gradle-bintray-plugin

If bintray-release support gradle 4.6 is best however because they don't even support gradle 4.5, I would like to drop this plugin and migrate to official one.

dharrigan · 2018-07-04T11:22:11Z

Hi,

Any progress on getting a new release out that supports Android X? I have a new project that fails to compile because v4 compat (ActivityCompat) is no longer available on the generated Dispatcher.

Thank you.

shiraji · 2018-07-05T02:11:50Z

I was working on replacing bintray-release with gradle-bintray-plugin. I'm not sure how I can test this fix at this moment.

hotchemi · 2018-07-05T02:13:57Z

Ah sorry I jus started working on from today @shiraji may be I'm a person to test🙇

shiraji · 2018-07-05T02:36:07Z

I'll push my code asap which is what I think it should. Then, you can test it. I really don't know if it works or not, thou

dharrigan · 2018-07-05T07:32:57Z

Happy to test out the new artifact when deployed :-)

-=david=-

hotchemi

👍

hotchemi · 2018-07-09T02:21:58Z

Thank you for your great work @shiraji !
I'll release 4.0.0-alpha1 tonight with some tests just in case!

codelishaohui · 2018-07-09T07:40:43Z

where is the 4.0.0-alpha1 ? ：）

hotchemi · 2018-07-09T07:58:33Z

Tonight!

dharrigan · 2018-07-09T09:43:37Z

Hi,

Well, testing...and it doesn't appear to work!

Android Studio 3.2 Beta 2
Build #AI-181.5281.24.32.4860949, built on June 25, 2018
JRE: 1.8.0_152-release-1136-b04 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.15.0-20-generic

implementation("com.github.hotchemi:permissionsdispatcher:4.0.0-SNAPSHOT") {
    exclude module: "support-v13"
}

annotationProcessor "com.github.hotchemi:permissionsdispatcher-processor:4.0.0-SNAPSHOT"

@RuntimePermissions
class MainActivity : AppCompatActivity() {

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_main)

    }

    override fun onRequestPermissionsResult(requestCode: Int, permissions: Array<out String>, grantResults: IntArray) {
        super.onRequestPermissionsResult(requestCode, permissions, grantResults)
    }

    @NeedsPermission(ACCESS_FINE_LOCATION)
    fun scanForDevices() {

    }

    @OnShowRationale(ACCESS_FINE_LOCATION)
    fun showRationaleForAccessFineLocation(request: PermissionRequest) {
        showRationaleDialog(R.string.permission_access_fine_location_rationale, request)
    }

    @OnPermissionDenied(ACCESS_FINE_LOCATION)
    fun onAccessFineLocationDenied() {
        makeText(this, R.string.permission_access_fine_location_denied, LENGTH_SHORT).show()
    }

    @OnNeverAskAgain(ACCESS_FINE_LOCATION)
    fun onAccessFineLocationNeverAskAgain() {
        makeText(this, R.string.permission_access_fine_location_never_ask_again, LENGTH_SHORT).show()
    }

    private fun showRationaleDialog(@StringRes messageResId: Int, request: PermissionRequest) {
        AlertDialog.Builder(this)
                .setPositiveButton(R.string.button_allow) { _, _ -> request.proceed() }
                .setNegativeButton(R.string.button_deny) { _, _ -> request.cancel() }
                .setCancelable(false)
                .setMessage(messageResId)
                .show()
    }

}

When doing a full build, no generated classes seem to be created, i.e., no scanForDevicesWithPermissionCheck. The generatedJava directory is empty except for the dispatcher, R class.

In my app build.gradle

dependencies {
    implementation fileTree(dir: 'libs', include: ['*.jar'])
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
    implementation 'androidx.appcompat:appcompat:1.0.0-beta01'
    implementation 'androidx.constraintlayout:constraintlayout:1.1.2'
    implementation 'si.inova:neatle:0.9.7'
    implementation 'commons-codec:commons-codec:1.11'

    implementation("com.github.hotchemi:permissionsdispatcher:4.0.0-SNAPSHOT") {
        exclude module: "support-v13"
    }

    testImplementation 'junit:junit:4.12'
    androidTestImplementation 'androidx.test:runner:1.1.0-alpha3'
    androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0-alpha3'

    annotationProcessor "com.github.hotchemi:permissionsdispatcher-processor:4.0.0-SNAPSHOT"
}

-=david=-

shiraji · 2018-07-09T10:21:00Z

@dharrigan Sorry if I confused you but it's not released, yet.

dharrigan · 2018-07-09T10:28:16Z

Hi,
Yup, I understand it's not released yet - but I was alerted that a snapshot was available for testing. That's what I'm doing - testing the snapshot and I've discovered it doesn't generate classes as it does in 3.3.1. Surely you would like this feedback?

-=david=-

hotchemi · 2018-07-09T11:03:53Z

@dharrigan thx for checking. are there any error log? I'm gonna test!

dharrigan · 2018-07-09T11:10:56Z

Hi,

No error logs - compilation succeeds normally.

dharrigan · 2018-07-09T11:13:00Z

Hi,

Actually, discovered the error.

I had annotationProcessor rather than kapt in my build.gradle - d'oh!

However, even with the snapshot 4.0 library (and the generated classes being generated), It's still complaining about Unresolved reference: ActivityCompat in MainActivityPermissionsDispatcher.

hotchemi · 2018-07-09T16:57:43Z

I'm testing but seems working? 👁

dharrigan · 2018-07-09T19:47:55Z

Hi,

Perhaps I'm missing something? I did a clean clone of the project, pulled down all the dependencies again, ensured I was using the 4.0.0-SNAPSHOT, did a build from the command line and I get the same error as in 3.3.1, i.e.,

Unresolved reference: ActivityCompat in MainActivityPermissionsDispatcher.kt

hotchemi · 2018-07-10T17:45:29Z

@dharrigan could you try 4.0.0-alpha? 👀 Seems we failed to release library module.

dharrigan · 2018-07-11T07:57:23Z

Hi,

Seems like the dependency fails:

Inside the pom

<dependency>
<groupId>PermissionsDispatcher</groupId>
<artifactId>annotation</artifactId>
<version>unspecified</version>
<scope>compile</scope>
</dependency>

When added as a depdency in build.gradle:

Failed to resolve: PermissionsDispatcher:annotation:unspecified
Open File
Show in Project Structure dialog

hotchemi · 2018-07-11T08:09:08Z

OMG sorry about that.

hotchemi · 2018-07-11T08:53:11Z

Umm why it happens..

hotchemi · 2018-07-11T08:54:19Z

@permissions-dispatcher/maintainers does anyone have an idea why this happens.. 🤔
#494 (comment)

shiraji · 2018-07-11T10:23:26Z

How we can generate pom file for library module?

hotchemi · 2018-07-11T13:46:03Z

@shiraji

PermissionsDispatcher/scripts/release.sh

Line 5 in 92540b7

./gradlew :library:bintrayUpload

I'll send needed info privately!

hotchemi · 2018-07-11T17:09:45Z

@dharrigan we've fixed by #500, can you try again?

shiraji mentioned this pull request Jun 26, 2018

AndroidX #488

Closed

shiraji force-pushed the shiraji/android_x_support branch from edd66c4 to b6729b3 Compare June 26, 2018 02:00

shiraji changed the title ~~[WIP] android x support~~ android x support Jun 26, 2018

shiraji requested review from hotchemi and mannodermaus June 26, 2018 02:03

Benjamin Müller and others added 12 commits June 27, 2018 05:38

made sample compile with Android Studio 3.2 alpha 18

76ee459

migrated to AndroidX

9f62537

adopted processors to honour new AndroidX package names

reverted commenting out some publishing infrastructure

7a7c9d0

extracted AndroidX version into gradle property

71bd595

import cleanup

f7d196e

updated travis.yml to platform 28

40f4fda

adds android licences to make travis happy

5103cae

copies licences to android home

08dd292

fixed all imports and tests again

4b4420f

my android studio was in a corrupt state and showed me a running app and tests...

Disable bintray release plugin until they support gradle-4.6

b26561f

Upgrade gradle plugin

12c0945

Fix the problem with onActivityResule's Intent nullable

ac625c5

shiraji force-pushed the shiraji/android_x_support branch from b6729b3 to ac625c5 Compare June 26, 2018 20:39

shiraji commented Jun 26, 2018

View reviewed changes

shiraji added 2 commits June 27, 2018 05:49

Format gradle.properties

662ef24

Remove unnecessary change

55cca20

shiraji mentioned this pull request Jun 26, 2018

Support androidx fragment #472

Closed

shiraji and others added 2 commits July 6, 2018 03:40

Introducing gradle-bintray-plugin

7cdd179

Tweak bintray plugin settings to work.

43e4921

hotchemi approved these changes Jul 9, 2018

View reviewed changes

hotchemi merged commit 5e50323 into master Jul 9, 2018

hotchemi deleted the shiraji/android_x_support branch July 9, 2018 02:21

zaclimon mentioned this pull request Jul 10, 2018

Update SDK to API 28 zaclimon/xipl#10

Closed

3 tasks

		@@ -9,6 +9,7 @@ import permissions.dispatcher.Utils.onNeedsPermission
		import permissions.dispatcher.Utils.onRationaleAnnotation
		import permissions.dispatcher.Utils.runtimePermission

android x support #494

android x support #494

Conversation

shiraji commented Jun 26, 2018 • edited by hotchemi

TODO

NOT TODO for this PR

shiraji commented Jun 26, 2018

hotchemi commented Jun 26, 2018

shiraji commented Jun 26, 2018

shiraji commented Jun 26, 2018

hotchemi commented Jun 26, 2018

shiraji Jun 26, 2018

Choose a reason for hiding this comment

hotchemi Jul 9, 2018

Choose a reason for hiding this comment

shiraji Jun 26, 2018

Choose a reason for hiding this comment

shiraji Jun 26, 2018

Choose a reason for hiding this comment

shiraji commented Jun 26, 2018

dharrigan commented Jul 4, 2018

shiraji commented Jul 5, 2018

hotchemi commented Jul 5, 2018

shiraji commented Jul 5, 2018

dharrigan commented Jul 5, 2018

hotchemi left a comment

Choose a reason for hiding this comment

hotchemi commented Jul 9, 2018

codelishaohui commented Jul 9, 2018

hotchemi commented Jul 9, 2018

dharrigan commented Jul 9, 2018 • edited

shiraji commented Jul 9, 2018

dharrigan commented Jul 9, 2018

hotchemi commented Jul 9, 2018

dharrigan commented Jul 9, 2018

dharrigan commented Jul 9, 2018

hotchemi commented Jul 9, 2018

dharrigan commented Jul 9, 2018

hotchemi commented Jul 10, 2018

dharrigan commented Jul 11, 2018 • edited

hotchemi commented Jul 11, 2018

hotchemi commented Jul 11, 2018

hotchemi commented Jul 11, 2018

shiraji commented Jul 11, 2018

hotchemi commented Jul 11, 2018

hotchemi commented Jul 11, 2018

shiraji commented Jun 26, 2018 •

edited by hotchemi

dharrigan commented Jul 9, 2018 •

edited

dharrigan commented Jul 11, 2018 •

edited