Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rk/fix python311 #52

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Rk/fix python311 #52

merged 4 commits into from
Jan 5, 2023

Conversation

roekatz
Copy link
Contributor

@roekatz roekatz commented Jan 5, 2023 •
edited

  1. Broadcast test wasn't parallel safe - executed container with a constant name (chances for the bug to occur in CI tests were drastically increased with the addition of Python 3.11 & 3.10 to the tests matrix).
  2. Bugfix in PubSubEndpoint calling asyncio.wait with an unwrapped coroutine (not supported in Python 3.11 - made broadcast test hang)
  3. Reverted skipping the broadcast tests - after solving those issues they now pass. (and we definitely want those to run)
  4. Have pytest run with timeout (Much easier to deal with hanging tests)

@roekatz roekatz requested review from orweis and asafc January 5, 2023 14:29
asafc
asafc approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@asafc asafc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roekatz roekatz merged commit 5d6d002 into master Jan 5, 2023
@roekatz roekatz deleted the rk/fix_python311 branch January 5, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafc asafc asafc approved these changes

@orweis orweis Awaiting requested review from orweis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roekatz @asafc