PubSubEndpoint: Don't disconnect all other subscribed endpoints when one disconnects #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug is canceling the reader task when the main_loop of a specific endpoint (/subscriber) is done.
roekatz
force-pushed
the
rk/fix-disconnections
branch
from
90f041d
to
528002f
Compare
roekatz
changed the title
asafc
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is canceling the broadcaster's reader task when the main_loop of a specific endpoint (/subscriber) is done.
Only the other way around is desirable (cancel the main loop if reader task is done - that is the experimental fix for the PG broadcaster connection loss) .