Improve publish performance #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roekatz
commented
Aug 6, 2023
roekatz
commented
- Use new broadcaster where connection pool is being used for Postgres backend.
- Avoid the publish lock by just using a new broadcaster instance for each publish (on PG a connection would just be acquired from the pool, on other backends a new connection would be established - but that was the case anyway).
- Fixed a bug of refcount locking in EventBroadcasterContextManager
- Improved logs a bit
And instead just creating a new broadcaster instance on every publish. The broadcaster instance was connected and disconnected every time anyway...
shaulk
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.