Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use redis-py to replace asyncio-redis #498

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Use redis-py to replace asyncio-redis #498

merged 6 commits into from
Sep 26, 2023

Conversation

calmzhu
Copy link
Contributor

@calmzhu calmzhu commented Sep 15, 2023

Fixes Issue

Close #497

Use redis.asyncio from redis-py to replace asyncio-redis.
Since package asyncio-redis had already been integrated to redis-py and abanded

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for opal-docs canceled.

Name Link
🔨 Latest commit 08798da
🔍 Latest deploy log https://app.netlify.com/sites/opal-docs/deploys/65128245c62036000870ecb7

@calmzhu calmzhu marked this pull request as ready for review September 16, 2023 10:13
@asafc
Copy link
Contributor

asafc commented Sep 18, 2023

Hi @calmzhu, thanks for the contribution!
It might take us a couple days to review due to workload (it's on @roekatz 's queue, no worries :))

@roekatz roekatz self-requested a review September 19, 2023 13:51
Copy link
Contributor

@roekatz roekatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calmzhu Looks good, well done!
Please fix pre-commit formatting issues, and I'll merge :)

@calmzhu
Copy link
Contributor Author

calmzhu commented Sep 26, 2023

Fixed in my local environment. Can you run this workflow again

misc/opa.config.yaml Outdated Show resolved Hide resolved
@roekatz roekatz merged commit 152d5fa into permitio:master Sep 26, 2023
10 checks passed
@roekatz
Copy link
Contributor

roekatz commented Sep 26, 2023

Thanks @calmzhu ! 🚀

@orweis
Copy link
Contributor

orweis commented Sep 26, 2023

Thanks @calmzhu 💪

@danielbass37 - please make sure to put him on our swag award list.

@danielbass37
Copy link
Contributor

@orweis I'd love to! @calmzhu are you in OPAL's Slack community?

@calmzhu
Copy link
Contributor Author

calmzhu commented Sep 27, 2023

@orweis I'd love to! @calmzhu are you in OPAL's Slack community?

Yes, i just joined.

@calmzhu calmzhu deleted the redis_replace branch September 27, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: duplicate base class TimeoutError in python3.11
5 participants