Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/fix-negative-open-price #43

Closed
wants to merge 3 commits into from
Closed

feat/fix-negative-open-price #43

wants to merge 3 commits into from

Conversation

tienshaoku
Copy link
Collaborator

@tienshaoku tienshaoku commented Apr 19, 2022 •
edited
Loading

@tienshaoku
Copy link
Collaborator Author

Not sure what is the convention of adding tests in this repo.
Thus, wrote some tests for PositionDraft as a start and can add more if necessary, ex: for Liquidity.getMakerPositionImpermanent() or Position.getExitPrice().

@tienshaoku tienshaoku self-assigned this Apr 19, 2022
@tienshaoku
Copy link
Collaborator Author

Done in perp-exchange instead:

  1. https://github.com/perpetual-protocol/perp-exchange/pull/589
  2. https://github.com/perpetual-protocol/perp-exchange/pull/590

@tienshaoku tienshaoku closed this Apr 20, 2022
@lsps9150414 lsps9150414 deleted the feat/fix-negative-open-price branch May 11, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tienshaoku tienshaoku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tienshaoku