Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code scanning alert - Prototype-polluting assignment #54

Closed
1 task done
perpk opened this issue Dec 16, 2022 · 0 comments · Fixed by #57
Closed
1 task done

Fix code scanning alert - Prototype-polluting assignment #54

perpk opened this issue Dec 16, 2022 · 0 comments · Fixed by #57
Assignees
@perpk
Labels
security There is a security vulnerability
Milestone
Version 1.3.0

Comments

@perpk
Copy link
Owner

perpk commented Dec 16, 2022 •
edited

Tracking issue for:
@perpk perpk added this to the Version 1.3.0 milestone Dec 16, 2022
@perpk perpk self-assigned this Dec 16, 2022
@perpk perpk added the security There is a security vulnerability label Dec 17, 2022
perpk added a commit that referenced this issue Dec 18, 2022
@perpk
Fix: Try to fix codeQL finding Issue #54
4428714
@perpk perpk mentioned this issue Dec 18, 2022
Merged
@perpk perpk linked a pull request Dec 18, 2022 that will close this issue
54 fix code scanning alert prototype polluting assignment #57
Merged
perpk added a commit that referenced this issue Dec 18, 2022
@perpk
Fix: Try to fix CodeQL finding #54 again
4a8141d
perpk added a commit that referenced this issue Dec 18, 2022
@perpk
Fix: Try to fix CodeQL finding #54 again
45f4be0
perpk added a commit that referenced this issue Dec 18, 2022
@perpk
Fix: Try to fix CodeQL finding #54 again
bd57a8a
perpk added a commit that referenced this issue Dec 18, 2022
@perpk
Fix: Try to fix CodeQL finding #54 again and again and again
787ae55
@perpk perpk closed this as completed in #57 Dec 20, 2022
perpk added a commit that referenced this issue Dec 20, 2022
@perpk
54 fix code scanning alert prototype polluting assignment (#57)
ed76be1 
* Fix #47 value-based mapping

* Chore: code linting

* Chore: replace trigger for tests with pr instead of push

* Chore: replace trigger for tests with pr instead of push

* test

* reset test comment

* Fix: Move nyc coverage action to separate job with node v14

* Fix: do an npm install before anything else in coverage job

* Fix: Download nyc-output from build job

* Fix: Wrong order of steps

* Fix: abs paths for up/download

* Fix: abs paths for up/download

* Fix: abs paths for up/download

* Fix: abs paths for up/download

* Chore: pre-commit linting and testing

* Fix: Set pre-commit scripts to executable

* Fix: linting findings

* Fix: Try to fix codeQL finding Issue #54

* Fix: Try to fix CodeQL finding #54 again

* Fix: Try to fix CodeQL finding #54 again

* Fix: Try to fix CodeQL finding #54 again

* Fix: Try to fix CodeQL finding #54 again and again and again

* Fix: revert to previous fix with assign of Object.create(null)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@perpk perpk

Labels
security There is a security vulnerability
Projects
None yet
Milestone
Version 1.3.0
Development

Successfully merging a pull request may close this issue.

54 fix code scanning alert prototype polluting assignment perpk/json-xform
1 participant
@perpk