Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDs to perry reports #40

Open
guilhermelimak opened this issue Oct 18, 2018 · 3 comments
Open

Add IDs to perry reports #40

guilhermelimak opened this issue Oct 18, 2018 · 3 comments

Comments

@guilhermelimak
Copy link
Collaborator

guilhermelimak commented Oct 18, 2018

Right now we don't have any identifiers on reports, it would be nice if we could generate a GUID on the client and keep the report ID consistent on all plugins.

We could use this function as a base and reinforce on the docs the need for checking for duplicates before saving the report, just to make sure.

What do you think @armand1m?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@armand1m
Copy link
Member

I liked the idea of using GUID's generated for each report.

There is also this npm module, with a small footprint https://www.npmjs.com/package/uuid

and this small gist they reference https://gist.github.com/jed/982883

@armand1m
Copy link
Member

I think this needs more discussion since I'm trying to figure out a good reason to have a GUID generated in the client-side.

As the bug reporting process is a bit ephemerous I don't really believe such thing would be needed :/

@armand1m
Copy link
Member

armand1m commented Mar 8, 2019

Today speaking with @JackTheRipper , it seems that actually there are some few cool cases where an GUID per report is useful. Also I think I had misunderstood your description last time @guilhermelimak , but I got your point this time, we should indeed have this GUID for each report generated by the client for consistency purposes

@armand1m armand1m added this to To do in Perry Client Mar 11, 2019
@armand1m armand1m removed this from To do in Perry Client Mar 11, 2019
@armand1m armand1m added this to To do in Perry Client Board Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants