Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stat function decodes the non-encoded filename #221

Closed
gijskant opened this issue Oct 12, 2020 · 3 comments · Fixed by #222
Closed

Stat function decodes the non-encoded filename #221

gijskant opened this issue Oct 12, 2020 · 3 comments · Fixed by #222

Comments

@gijskant
Copy link
Contributor

The stat function does a PROPFIND request to the server and then parses the XML data in the response. At that stage, the filename that was given to the stat function as parameter (not encoded) is normalised (see stat.js), which includes url-decoding the name.
This causes a failure when the filename contains a % character.

The url-decoding happens in url.js and was added in response to #68.
@gijskant gijskant mentioned this issue Oct 12, 2020
Merged
perry-mitchell added a commit that referenced this issue Oct 15, 2020
@perry-mitchell
Add failing tests for #221
519ead0
@perry-mitchell
Copy link
Owner

perry-mitchell commented Oct 15, 2020 •
edited

@gijskant I added a failing test in 519ead0 which supports your find.

Didn't realise you added one, sorry.

@perry-mitchell
Copy link
Owner

Released as 3.6.1 - Thanks @gijskant!

@gijskant
Copy link
Contributor Author

Thank you very much for your fast response! And thanks for maintaining such a useful library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix stat (PROPFILE) request file files with '%' in the filename. thehyve/webdav-client
2 participants
@perry-mitchell @gijskant