fix: Do not double decode XML entities in filenames #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `href` property is already decoded by `parseXML` meaning all XML entities like `&` were decoded. The href just needs to be url decoded. This prevents issues were files like `a & b.txt` were returned with the wrong name `a & b.txt` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
8 tasks
|
Thanks @susnux ! Everything looks good here so I'll merge. |
perry-mitchell
approved these changes
Feb 5, 2024
|
@susnux Released in 5.3.2 |
|
Thank you very much for the quick bugfix release! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hrefproperty is already decoded byparseXMLmeaning all XML entities like&were decoded. The href just needs to be url decoded.This prevents issues were files like
a & b.txtwere returned with the wrong namea & b.txtRef: https://datatracker.ietf.org/doc/html/rfc4918#section-8.3