Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue144 #147

Merged
merged 20 commits into from Sep 5, 2016
Merged

Issue144 #147

merged 20 commits into from Sep 5, 2016

Conversation

darthunix
Copy link
Contributor

A pull request, closing issue144 and closing TODOs in constraint.py.

  • on index columns change drop/add index
  • on primary key columns change drop/add primary key
  • on foreign keys columns/match/actions change drop/add foreign key
  • on unique constraint change drop/add constraint

@jmafc jmafc merged commit c99c584 into perseas:r0.7 Sep 5, 2016
@jmafc
Copy link
Member

jmafc commented Sep 5, 2016

@darthunix In future PRs, you may want to aggregate commits, e.g., use git commit --amend when you notice the "ooops" or use git rebase --interactive to squash several commits. Having fewer individual commits also makes it easier to merge changes to other branches.

@darthunix
Copy link
Contributor Author

Thanks for advice. I promise to read git cookiebook on weekends)

@darthunix darthunix mentioned this pull request Sep 6, 2016
jmafc added a commit that referenced this pull request Sep 6, 2016
    Most of the work done by Denis Smirnov <darthunix@gmail.com>.
jmafc added a commit that referenced this pull request Dec 12, 2016
…ep 16).

  26-10-15 afd5fe3 Constraints failing tests: change of column order.
  26-10-15 a7090d2 Foreign keys: alter column references, change actions.
  26-10-15 3b8beb7 Foreign keys: separating of column indexes and names.
  23- 2-16 c58e914 Fix problem introduced by 5da6b0c, causing sequence empty
                   privs to show as []. (jmafc)
  28- 7-16 8d5d06e In ForeignKey.diff_map, ensure ref_col_idxs is present in
                   in input map. (jmafc)
  29- 8-16 465e76e Merge PRs #142 and #145 from r0.7 to master branch. Fixes
                   issue #141.
   6- 9-16 c13c543 Merge PR #148 from r0.7 to master. Fixes #144.
   6- 9-16 3de4f3a Merge PRs #147 from r0.7 to master branch. Fixes issue
                   #144.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants