Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] fix portName reference in ingress #9

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

hairmare
Copy link
Contributor

Description

We found the following error when trying to configure an Ingress using version 0.1.2 of the chart.

$ helm install perses perses/perses --set ingress.ingressClassName=nginx --set ingress.enabled=true
Error: INSTALLATION FAILED: 1 error occurred:
        * Ingress in version "v1" cannot be handled as a Ingress: json: cannot unmarshal number into Go struct field ServiceBackendPort.spec.rules.http.paths.backend.service.port.name of type string

This PR aims at fixing it by introducing service.portName.

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, IGNORE.
  • All commits have DCO signoffs.

Signed-off-by: Lucas <lucas.bickel@adfinis.com>
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oupsy oupsy. Thank you for fixing it !!

@Nexucis Nexucis merged commit 496af38 into perses:main Sep 15, 2023
2 checks passed
@hairmare hairmare deleted the fix/portName-in-ingress branch September 17, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants