-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] 1rst version of a CUE-based Dashboard-as-Code framework #1664
[FEATURE] 1rst version of a CUE-based Dashboard-as-Code framework #1664
Conversation
842313c
to
9ae1669
Compare
8101114
to
b02a73b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work already !
I think we can simplify the setup by saving in the perses repo the cue files generated and by adding a dac
subcommand in the CLI !
-v version of Perses (in the form of \"X.Y.Z\") from which to retrieve the dependencies | ||
|
||
Example: | ||
$ ./dac_setup.sh -v 0.42.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to ease the cross platform support, why not including that in the CLI ?
like under the command percli dac init --language=cue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes since we already planned to add such dac
subcommand in the CLI for other stuff, I was thinking of something like this but for a next PR, but yes we can already do this move if you want
e14adda
to
515cbea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so cool, that's a really nice start !!
As a side note I think you need to re-generate the cue files with the new URL type we added in the pkg /model/api/v1/common
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
…e base CUE definitions + integrate DaC validation in `make cue-test` Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
… + improve dac test to show precise diff when fail Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
…ate import paths accordingly Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
…E files in `make fmt` + fix formatting + exclude *_go_gen.cue files from license check Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
…val` covering all files with 1 command + less diff in makefile Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
fc89399
to
5af6377
Compare
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
5af6377
to
c0d709f
Compare
Description
This PR brings a first version of what we can call a Dashboard-as-Code framework. More precisely:
cue/dac-utils
Besides, for the "internal" part of this PR:
cue-gen
added to Makefile to generate the CUE definitions from to the Golang datamodel. This is needed for the DaC framework validation (= new tests associated tocue-test
target)cue
folder at the root, so I had to update many files to update the schemas paths accordingly.cue get go
generation (see comments in the files for more details)Checklist
[<catalog_entry>] <commit message>
naming convention using one of thefollowing
catalog_entry
values:FEATURE
,ENHANCEMENT
,BUGFIX
,BREAKINGCHANGE
,DOC
,IGNORE
.