-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] percli dac setup
adds output dir to .gitignore
#1710
[ENHANCEMENT] percli dac setup
adds output dir to .gitignore
#1710
Conversation
89987eb
to
447e6ae
Compare
72e8bd5
to
0b16851
Compare
'should make this idempotent by adding a check to avoid appending to gitignore if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want my opinion, I'm not fan of pre-assuming that the user of your tool want to create a git repo, or want to use git as a version manager or even want to ignore the built folder.
That's easier to have a doc saying.
git init
percli dac setup
echo "built" >> .gitignore
Less code to maintain and the three lines are self explanatory.
I would be in the middle here:
# folder used to store the result of the command percli dac build
/built
Finally, it would be great to be able to change the targeted folder too. |
7b8e8e5
to
aee1939
Compare
percli dac setup
percli dac setup
adds output dir to .gitignore
aee1939
to
ba95ff7
Compare
2ddcff9
to
cdfd1ab
Compare
1ae0d7b
to
7e23bb8
Compare
1b16792
to
ea8cb96
Compare
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
ea8cb96
to
a8914b6
Compare
Description
Just a simple addition to avoid further manual steps to the DaC users.
This step is skipped if the .gitignore file is not already present.
Checklist
[<catalog_entry>] <commit message>
naming convention using one of thefollowing
catalog_entry
values:FEATURE
,ENHANCEMENT
,BUGFIX
,BREAKINGCHANGE
,DOC
,IGNORE
.