Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Allow dynamic selection of authentication provider in percli #1735

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

celian-garcia
Copy link
Member

@celian-garcia celian-garcia commented Jan 30, 2024

Description

This PR clarifies the current support of different authentication providers by percli. It removes any doubt with clear messages on what we can do and cannot and it starts the implementation with a simple selector.

Screenshots

When backend support several auth provider. The command line ask you to select

image

... with an error message for the moment for OIDC/OAuth 2.0, as it is not supported by the CLI

image

When the backend does not support native, we cannot set username or password arguments

image
image

One can set the provider through argument (it might be useful when we'll implement the client credentials flow)

image

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@celian-garcia celian-garcia self-assigned this Jan 31, 2024
@celian-garcia celian-garcia added the cli something related to the CLI label Jan 31, 2024
@celian-garcia celian-garcia force-pushed the feat/device-code branch 2 times, most recently from 453ec93 to 596422e Compare January 31, 2024 09:59
@celian-garcia celian-garcia marked this pull request as ready for review January 31, 2024 09:59
celian-garcia

This comment was marked as outdated.

@celian-garcia celian-garcia force-pushed the feat/device-code branch 3 times, most recently from 39b6521 to 02d9d53 Compare January 31, 2024 16:27
…ercli

Signed-off-by: Celian GARCIA <celian.garcia@amadeus.com>
@celian-garcia celian-garcia added this pull request to the merge queue Feb 1, 2024
Merged via the queue into perses:main with commit 6474f67 Feb 1, 2024
18 checks passed
@celian-garcia celian-garcia deleted the feat/device-code branch February 1, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli something related to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants