Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] CUE SDK: better UX with panel groups + enforce SDKs alignment #1743

Merged

Conversation

AntoineThebaud
Copy link
Contributor

@AntoineThebaud AntoineThebaud commented Feb 6, 2024

Description

  • CUE SDK: better UX with panel groups (add successive rows, same as with Golang SDK).
    • This involved adding a new dashboard builder utility, that also simplifies things by "flattening" other parts of the model like metadata.
  • Enforce SDKs alignment by using same sample output in unit tests.
  • Some formatting following the recent upgrade to cue v0.7.0.

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

@AntoineThebaud AntoineThebaud force-pushed the antoinethebaud/cue-sdk-rework-rows branch 3 times, most recently from d0db24d to 5b4128a Compare February 6, 2024 07:58
…gnment by using same sample output in unit tests

Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud force-pushed the antoinethebaud/cue-sdk-rework-rows branch from 5b4128a to 4e7f34b Compare February 6, 2024 08:25
]
}
}
success: fals
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I changed this because a dumb file is enough to check the invalid syntax case.

@AntoineThebaud AntoineThebaud marked this pull request as ready for review February 6, 2024 08:36
Copy link
Member

@Gladorme Gladorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AntoineThebaud AntoineThebaud merged commit b0fbb5b into feat/dashboard-as-code Feb 6, 2024
19 checks passed
@AntoineThebaud AntoineThebaud deleted the antoinethebaud/cue-sdk-rework-rows branch February 6, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants