Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add doc + renaming row to panel group #1759

Merged
merged 9 commits into from
Feb 14, 2024

Conversation

Gladorme
Copy link
Member

Description

Last details for Go SDK with more doc

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
@Gladorme Gladorme marked this pull request as ready for review February 14, 2024 13:44
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
@Nexucis
Copy link
Member

Nexucis commented Feb 14, 2024

nice ! Can you add an example on each docs please ? Thanks

Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Copy link
Contributor

@AntoineThebaud AntoineThebaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just spotted one typo

docs/dac/go/prometheus/query.md Outdated Show resolved Hide resolved
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome !! Thank you !

@Nexucis Nexucis merged commit 3947ddc into feat/dashboard-as-code Feb 14, 2024
19 checks passed
@Nexucis Nexucis deleted the gladorme/go-sdk-finitions branch February 14, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants